EC #7694
EC #7694
Conversation
|
@hellohuanlin any chance you can look at the generated swift code and let me know if there is a more idiomatic way to do this? |
packages/pigeon/platform_tests/test_plugin/ios/Classes/CoreTests.gen.swift
Outdated
Show resolved
Hide resolved
| func onCancel(withArguments arguments: Any?) {} | ||
| } | ||
|
|
||
| class PigeonEventSink<T> { |
There was a problem hiding this comment.
It looks like this is just a 1-line wrapper? Can we just inline the calls?
There was a problem hiding this comment.
What do you mean by "inline" specifically?
There was a problem hiding this comment.
Can we directly use the wrapped type rather than using this wrapper?
There was a problem hiding this comment.
no, the purpose of this wrapper is to enforce type safety on the return value
There was a problem hiding this comment.
By type safety you mean the generic type T in the success(_ value:) call?
There was a problem hiding this comment.
yeah, so I see what you mean, the error method isn't needed. I'm not sure if this is it's final form, but if it is, I'll remove it.
packages/pigeon/platform_tests/test_plugin/ios/Classes/TestPlugin.swift
Outdated
Show resolved
Hide resolved
packages/pigeon/platform_tests/test_plugin/ios/Classes/TestPlugin.swift
Outdated
Show resolved
Hide resolved
packages/pigeon/platform_tests/test_plugin/ios/Classes/TestPlugin.swift
Outdated
Show resolved
Hide resolved
Syntax is all I was really hoping for :) Thank you. Just wanted to make sure there wasn't a more idiomatic way to handle the class structure and inheritance and such. |
No description provided.