Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(installation-spell): print logs on a service #291

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/aqua/installation-spell/src/aqua/spell.aqua
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ func download_service(s: Service, ipfs: Multiaddr) -> []Hash:
for m <- s.modules:
get_wasm <- get_from(HOST_PEER_ID, m.wasm, ipfs)
if get_wasm.success:
on HOST_PEER_ID:
try:
try:
on HOST_PEER_ID:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that need to be executed on host and not on worker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because aqua-ipfs is available only on host.

hashes <<- Dist.add_module_bytes_from_vault(m.name, get_wasm.path)
catch e:
log([s.name, "error adding module", m.name, e])
catch e:
log([s.name, "error adding module", m.name, e])
else:
log([s.name, "error retrieving module", m.name, ["wasm", m.wasm, get_wasm]])
<- hashes
Expand Down
Loading