feat: improve error message when matching too soon [fixes DXJ-771] #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
changed the title
| if ( | ||
| !( | ||
| lastMatchedEpoch === 0n || | ||
| currentEpoch > lastMatchedEpoch + minDealRematchingEpochs |
There was a problem hiding this comment.
not sure about this sign,
also, there are updated on the part of the ts-client: https://github.com/fluencelabs/deal/pull/429
There was a problem hiding this comment.
I am taking this logic right from the contracts, basically I think I have the same condition as in solidity code. You can check it out and confirm if I am correct
…XJ-776] (#914) * feat: allow selecting a deployment when creating a new service [fixes DXJ-776] * improve * fix offers flag description * Apply automatic changes --------- Co-authored-by: shamsartem <[email protected]>
* feat: update all of the dependencies * feat: update dependencies * Apply automatic changes * remove ^ * simplify * run tests in parallel * try * make tests concurrent * try * remove concurrency * remove not used dep * Apply automatic changes * up * wrap tests and fix * Apply automatic changes * stop duplicating messages in tests * add a bit better explanation on how to run tests * switch types to node 18 --------- Co-authored-by: shamsartem <[email protected]>
… RPC error (#929) * feat: chunk CUs when withdrawing collateral, add retry for Tendermint RPC error * Apply automatic changes * improvements * fix * Apply automatic changes * Apply automatic changes --------- Co-authored-by: shamsartem <[email protected]> Co-authored-by: fluencebot <[email protected]>
…fixes DXJ-778] (#931) * fix: filter provider's CUs when exiting from deals. Add CU batching [fixes DXJ-778] * Apply automatic changes * remove max-cus * Apply automatic changes * up rust log * fix --------- Co-authored-by: shamsartem <[email protected]>
* feat: increase particle timeout * leave one test to fail once * run multiple tests * run only update tests * try removing constraint * run all * test improvements * improve * up * fix * better errors? * fix error representation * more errors improvements * remove quite flag * add system_cpu_count and cpus_range * separate into steps, fail fast * share env variables * add env * decider_period_sec = 60 * add expired=info * add print_config = true * change rust log * change rust log * up * add print config fflag * fix * fix? * Update dockerCompose.ts * Update dockerCompose.ts * Update provider.ts * comment out systemCpuCount and cpusRange * remove --------- Co-authored-by: Nick <[email protected]>
* fix(deps): deal-ts-clients 0.15.1 * fix(dar,stage): update Dar rpc, stage ipfs
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(main): release fluence-cli 0.17.1 * Apply automatic changes --------- Co-authored-by: fluencebot <[email protected]>
…l withdrawal [fixes JS-783] (#992) * fix(deps): update dependency @fluencelabs/deal-ts-clients to v0.15.2 * feat(provider): withdraw collateral before remove CU from CC * Apply automatic changes --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: folex <[email protected]>
* feat(kras)!: switch kras chain to raas * fix(deps): deal-ts-clients 0.15.3, kras on raas
… working on firefox (#994) * fix(cli-connector): switch chain networks reliably, fix connector not working on firefox * don't suggest to switch network if user canceled
* feat: add provider test * Apply automatic changes * fix * add cc-collateral-withdraw * Apply automatic changes * add offers flag * Apply automatic changes * activate * check cc-info status * fix import and messages * remove asserts * Apply automatic changes * add chain RPC to chain info * add marine and mrepl paths to fluence dep v * Apply automatic changes * improve flags * Apply automatic changes * fix(cli-connector): switch chain networks reliably, fix connector not working on firefox (#994) * fix(cli-connector): switch chain networks reliably, fix connector not working on firefox * don't suggest to switch network if user canceled * use 30 seconds cc duration --------- Co-authored-by: shamsartem <[email protected]>
* feat: offer-info updates [fixes DXJ-770] * Apply automatic changes * add connection closed to the list of the errors to retry * add debug log * fix? * fix? * improve * updates * Apply automatic changes * update the message * increase ttl * Apply automatic changes --------- Co-authored-by: shamsartem <[email protected]>
* feat: update aqua-lib 0.11.0 * update nox config * Apply automatic changes * remove deprecated stuff from decider * Apply automatic changes * add some logs * turn on logs * increase ttl * Apply automatic changes * use 0.26.0 --------- Co-authored-by: shamsartem <[email protected]>
* fix(deps): deal-ts-clients 0.15.4, new stage & testnet contracts * fix(versions): revert nox version to 0.26.0
* chore(main): release fluence-cli 0.18.0 * Apply automatic changes --------- Co-authored-by: fluencebot <[email protected]>
…ted (#998) * fix: add retry to getting offers info from indexer when offer is created * use dbg for ipfs operations logging
Use centralized configs
* feat: many CUs in worker * Apply automatic changes * use nox with multiCU * up * improve workers remove, rename property in provider config * fix * Apply automatic changes * fix * strip ansi colors from connector messages * add provider name to provider info * improve tx error * return descriptions * Apply automatic changes * add new line * remove price per worker epoch mentions * Apply automatic changes * fix(deps,deal): update multicu deal-ts-clients, fix deal init balance calc * Apply automatic changes * fix account switching, update default curl CID * fix offer update false positives * chore(versions): set nox 0.26.1 * update versions.json * Update cli/src/versions.json * feat: chunk offer create (#1004) * feat: chunk offer create * add chunking to update offer * fix(deal-ts-clients): rename Multicall import to IMulticall (#1005) * fix(deal-ts-clients): rename import * fix(deps): revert version, keep fix * Apply automatic changes * Apply automatic changes * fix(deps)!: deal-ts-clients 0.18.0 --------- Co-authored-by: shamsartem <[email protected]> Co-authored-by: folex <[email protected]> Co-authored-by: folex <[email protected]> Co-authored-by: Alexey Proshutinskiy <[email protected]> Co-authored-by: fluencebot <[email protected]>
* chore(main): release fluence-cli 0.19.0 * Apply automatic changes --------- Co-authored-by: fluencebot <[email protected]>
* feat(vm): add vmConfig to computePeer.nox * Apply automatic changes * fix(config): vmConfig => vm * Apply automatic changes --------- Co-authored-by: folex <[email protected]>
* chore(main): release fluence-cli 0.19.1 * Apply automatic changes --------- Co-authored-by: fluencebot <[email protected]>
* feat: many CUs in worker * Apply automatic changes * use nox with multiCU * up * improve workers remove, rename property in provider config * fix * Apply automatic changes * fix * strip ansi colors from connector messages * add provider name to provider info * improve tx error * return descriptions * Apply automatic changes * add new line * remove price per worker epoch mentions * Apply automatic changes * fix(deps,deal): update multicu deal-ts-clients, fix deal init balance calc * Apply automatic changes * fix account switching, update default curl CID * fix offer update false positives * chore(versions): set nox 0.26.1 * update versions.json * Update cli/src/versions.json * feat: chunk offer create (#1004) * feat: chunk offer create * add chunking to update offer * fix(deal-ts-clients): rename Multicall import to IMulticall (#1005) * fix(deal-ts-clients): rename import * fix(deps): revert version, keep fix * feat: create only one ipfs client * debug all * use specific container version * use a different ipfs version * push cli version, don't allow to send tx if wallet is different * show warnings instead of failing on offer create * improve contributing doc * fix --------- Co-authored-by: shamsartem <[email protected]> Co-authored-by: folex <[email protected]> Co-authored-by: folex <[email protected]> Co-authored-by: Alexey Proshutinskiy <[email protected]>
* fix(vm_config): add hostSshPort and vmSshPort to Nox's vmConfig * Apply automatic changes * Apply suggestions from code review * Apply automatic changes --------- Co-authored-by: folex <[email protected]>
* fix(provider)!: rename rewardDelegationRate to stakerReward * Apply automatic changes * add migration * Apply automatic changes --------- Co-authored-by: folex <[email protected]> Co-authored-by: Artsiom Shamsutdzinau <[email protected]> Co-authored-by: shamsartem <[email protected]>
* chore(main): release fluence-cli 0.19.2 * Apply automatic changes --------- Co-authored-by: fluencebot <[email protected]>
…dress is in provider artifacts for current env (#1019) * feat: don't require connecting wallet on provider info if provider address is in provider artifacts for current env * Apply automatic changes * Update cli/src/lib/const.ts Co-authored-by: folex <[email protected]> * Apply automatic changes --------- Co-authored-by: shamsartem <[email protected]> Co-authored-by: folex <[email protected]>
* feat: add offer-remove command * Apply automatic changes * simplify --------- Co-authored-by: shamsartem <[email protected]>
* feat!: update default ports * Apply automatic changes * update description * Apply automatic changes --------- Co-authored-by: shamsartem <[email protected]>
* feat: up deal-ts-clients, show additional cc-info for providers * format flt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.