Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(air): introduce explicit types for generation numbers [fixes VM-261] #530

Merged
merged 17 commits into from
Apr 10, 2023
Merged

feat(air): introduce explicit types for generation numbers [fixes VM-261] #530

merged 17 commits into from
Apr 10, 2023

Conversation

orchimada
Copy link
Contributor

Fixed generation types (including enum Generation). Thx to Michael <3

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mikevoronov
mikevoronov approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mikevoronov mikevoronov self-requested a review March 23, 2023 16:10
@mikevoronov mikevoronov self-requested a review March 23, 2023 23:33
@mikevoronov mikevoronov added A-trace-handler area: components related to CRDT data C-dx category: developer experience improvements A-execution-engine area: execution engine of AquaVM T-hardening track: hardening labels Mar 23, 2023
@coveralls
Copy link

coveralls commented Mar 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4656886994

  • 99 of 127 (77.95%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 83.629%
Changes Missing Coverage Covered Lines Changed/Added Lines %
air/src/execution_step/boxed_value/stream.rs 41 51 80.39%
crates/air-lib/interpreter-data/src/generation_idx.rs 17 35 48.57%
Totals Coverage Status
Change from base Build 4656816740: -0.07%
Covered Lines: 15959
Relevant Lines: 19083
💛 - Coveralls

@mikevoronov mikevoronov added the e2e Run e2e workflow label Apr 7, 2023
@mikevoronov mikevoronov changed the title chore(air): introduce explicit types for generation numbers feat(air): introduce explicit types for generation numbers Apr 9, 2023
monoid
monoid approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@monoid monoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mikevoronov mikevoronov merged commit d62fa6f into fluencelabs:master Apr 10, 2023
@fluencebot fluencebot mentioned this pull request Apr 10, 2023
Merged
@mikevoronov mikevoronov changed the title feat(air): introduce explicit types for generation numbers feat(air): introduce explicit types for generation numbers [fixes VM-261] Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monoid monoid monoid approved these changes

@mikevoronov mikevoronov Awaiting requested review from mikevoronov

Assignees

@orchimada orchimada

Labels
A-execution-engine area: execution engine of AquaVM A-trace-handler area: components related to CRDT data C-dx category: developer experience improvements e2e Run e2e workflow T-hardening track: hardening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orchimada @CLAassistant @coveralls @monoid @mikevoronov @nahsi