Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalFormats to fallback and make formats public #415

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Aug 25, 2024

Based on #372.

Made current auto formats public for users to be able to cherrypick.

@Amir-P Amir-P requested a review from amantoux August 25, 2024 18:38
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (e60be6c) to head (cb8fa8a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          62       62           
  Lines       10363    10364    +1     
=======================================
+ Hits         9114     9115    +1     
  Misses       1249     1249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I guess the natice autoformats are made public to allow users to cherrypick
It would be nice to add a comment in the PR (to avoid guessing the reason :))

Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add test?

@Amir-P
Copy link
Member Author

Amir-P commented Aug 25, 2024

Maybe add test?

I found it unnecessary, but if you think it's needed I can add the test too. @amantoux

@amantoux
Copy link
Member

Maybe add test?

I found it unnecessary, but if you think it's needed I can add the test too. @amantoux

If not too long to write, I think it is worth

@Amir-P Amir-P requested a review from amantoux August 25, 2024 19:34
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amantoux amantoux merged commit b98743a into master Aug 26, 2024
4 checks passed
@Amir-P Amir-P deleted the feat/use_custom_formats branch August 26, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants