Always keep natural order of selection boundaries #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amantoux
force-pushed
the
fix/incorrect_delta_slice_when_setting_data_to_clipboard
branch
from
14d871e
to
6dd68a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 87.91% 87.91%
=======================================
Files 62 62
Lines 10331 10331
=======================================
Hits 9083 9083
Misses 1248 1248 ☔ View full report in Codecov by Sentry. |
Amir-P
reviewed
Aug 11, 2024
|
@Amir-P can you please review? |
when setting clipboard data
amantoux
force-pushed
the
fix/incorrect_delta_slice_when_setting_data_to_clipboard
branch
from
5d0f6b5
to
4bdf00a
Compare
Amir-P
deleted the
fix/incorrect_delta_slice_when_setting_data_to_clipboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when setting clipboard data, selection extent can be inverted (notably on macOS) if selection was made from end to start
This fixes the issue by calling Delta::slice with natural order of selection extents