Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear controller feature #393

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Add clear controller feature #393

merged 2 commits into from
Aug 8, 2024

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Aug 5, 2024 •
edited
Loading

Fixes #382

@Amir-P Amir-P requested a review from amantoux August 5, 2024 19:21
@codecov Codecov
Copy link

codecov bot commented Aug 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (9c5818d) to head (d804b15).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   87.93%   87.94%   +0.01%     
==========================================
  Files          61       61              
  Lines       10299    10311      +12     
==========================================
+ Hits         9056     9068      +12     
  Misses       1243     1243

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amir-P Amir-P mentioned this pull request Aug 5, 2024
Closed
amantoux
amantoux requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's look good to me overall, there are some nitpicks
Can you please take a look?

packages/fleather/lib/src/widgets/controller.dart Outdated Show resolved Hide resolved
packages/fleather/test/widgets/controller_test.dart Outdated Show resolved Hide resolved
@Amir-P Amir-P requested a review from amantoux August 8, 2024 09:19
amantoux
amantoux approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amantoux amantoux merged commit ed88896 into master Aug 8, 2024
4 checks passed
@Amir-P Amir-P deleted the feat/clear_controller branch August 8, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add controller's clear() method
2 participants
@Amir-P @amantoux