Add localizations #391
Add localizations #391
Conversation
…ialog and headings
|
I can see that it's marked as a draft. Let me know when it's ready for review. |
|
Indeed, I didn't add localizations for all the strings in the package, that's the only thing that's missing (and fixing tests). I'll tag you when I'm done. |
|
I've added the other strings, with translations in english and french. Now other languages can be supported just by adding their ARB files. I've scrolled through all the code to find strings to translate so I hope I didn't miss any. I've also fixed the tests. So the PR is ready for review now! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 87.93% 87.90% -0.03%
==========================================
Files 61 62 +1
Lines 10299 10329 +30
==========================================
+ Hits 9056 9080 +24
- Misses 1243 1249 +6 ☔ View full report in Codecov by Sentry. |
|
Are you ok with me pushing a commit on this branch? I had too many improvements in mind that would be a bit time consuming to write and also for you to apply. @maelchiotti |
|
Yes of course you can! |
|
Can you please take a look and let me know what you think about the changes? It also would have been better if we could completely ignore generated files from the plugin, but looks like those files don't get generated when |
|
The changes look good to me! |
|
do you mind if I commit a change to the repo to avoid having the **.g.dart files in the coverage stats? |
Cocorico :) |
| @@ -1,12 +1,9 @@ | |||
| import 'dart:async'; | |||
|
|
|||
| import 'package:fleather/src/widgets/editor.dart'; | |||
| import 'package:fleather/fleather.dart'; | |||
There was a problem hiding this comment.
We should avoid importing via package for internal files, can you please use relative path?
| @@ -1,12 +1,9 @@ | |||
| import 'dart:async'; | |||
|
|
|||
| import 'package:fleather/src/widgets/editor.dart'; | |||
| import 'package:fleather/fleather.dart'; | |||
| import 'package:fleather/l10n/l10n.dart'; | |||
| @@ -1,7 +1,8 @@ | |||
| import 'package:fleather/fleather.dart'; | |||
| @@ -1,7 +1,8 @@ | |||
| import 'package:fleather/fleather.dart'; | |||
| import 'package:fleather/l10n/l10n.dart'; | |||
|
Feel free to tag me if you add a new string anytime, so I can translate it in french directly 😊 |
It shouldn't be a problem, I'm French too 🥖 |
|
Aha awesome 🥖🥖 |
Add default localizations with a delegate.