Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light theme inline code correct color #151

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Light theme inline code correct color #151

merged 1 commit into from
Jul 6, 2023

Conversation

amantoux
Copy link
Member

@amantoux amantoux commented Jul 6, 2023 •
edited
Loading

Fixes #147

Material 3 (inline code)
image

Material 2 (inline code)
image

@amantoux amantoux requested a review from Amir-P July 6, 2023 19:19
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #151 (37179c9) into master (a49cd20) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files          60       60           
  Lines        9348     9348           
=======================================
  Hits         7854     7854           
  Misses       1494     1494
Impacted Files Coverage Δ
packages/fleather/lib/src/widgets/theme.dart 94.11% <100.00%> (ø)

@amantoux
Copy link
Member Author

amantoux commented Jul 6, 2023

@Amir-P if you wish to take a quick look?

Amir-P
Amir-P approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amir-P Amir-P merged commit 3590e3d into master Jul 6, 2023
4 checks passed
@Amir-P Amir-P deleted the amantoux/issue147 branch July 6, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amir-P Amir-P Amir-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light theme inline code wrong color
2 participants
@amantoux @Amir-P