Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LabeledEvents #92

Closed
magland opened this issue Aug 1, 2023 · 4 comments
Closed

Support LabeledEvents #92

magland opened this issue Aug 1, 2023 · 4 comments

Comments

@magland
Copy link
Collaborator

magland commented Aug 1, 2023

See #89 (comment)

@magland
Copy link
Collaborator Author

magland commented Aug 2, 2023

From Cody:

I'd say a general strategy for this would be a raster whose number of 'units' (columns or Y axis) is the number of unique labels

@magland
Copy link
Collaborator Author

magland commented Aug 2, 2023

@CodyCBakerPhD
Copy link
Contributor

CodyCBakerPhD commented Aug 2, 2023

One idea on how to display the labels better could be to color each each one and have a separate legend on the side for matching color to string label, which should get give plenty of room for longer label names

I was going to suggest that initially instead of splitting each unique label over the Y axis, but it occurred to me that it's possible to have a fairly large number of labels (as with MoSeq, which will likely be one of the more common instances of this data structure once the extension gains popularity) so I didn't want distinct consecutive event times from similarly colored (but different) labels to cause confusion - so even with coloration I still think utilization of the Y axis is the way to go

Only other issue I found with this viewer is that by default it starts with the time range zoomed out to the max - that's fine when just viewing it in an isolated tab but when displaying against another series (neural or in this case video/pose) it either takes a long time or stalls out on the other tabs

https://flatironinstitute.github.io/neurosift/?p=/nwb&url=https://dandiarchive.s3.amazonaws.com/blobs/80d/c44/80dc4460-7652-4b88-97ce-69a7e8be5d60&tab=neurodata-items:neurodata-item:/processing/behavior/RewardEventsLinearTrack|LabeledEvents@neurodata-item:/processing/behavior/LinearMazePositionTracking/SpatialSeriesRaw|SpatialSeries@view:X/Y|/processing/behavior/LinearMazePositionTracking/SpatialSeriesRaw

image

@magland
Copy link
Collaborator Author

magland commented Aug 2, 2023

@CodyCBakerPhD thanks for those suggestions. At this point, I don't know a good solution to displaying the long labels on the raster plot. One consideration is that we want the time axes to line up properly between widgets in the multi-view mode. That means we can't easily make additional room for long labels or a legend. I am going to open a new issue for this one, and we can think about what to do.

I also don't know how to solve the issue with the initial visible time range. The problem is that different widgets have different rules for how much to display on start-up, and so when there are multiple views, there is a race condition controlling which one wins out. I will open a separate issue for that as well.

So with those two separate issues, I am going to close this. Feel free to reopen if there are other items to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants