Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Recognize ndx-events objects for event times raster plots? #89

Closed
tuanpham96 opened this issue Jul 25, 2023 · 8 comments

Comments

@tuanpham96
Copy link

I got this error when I tried loading an AnnotatedEventsTable created with ndx-events.

View plugin not found: neurodata-item:/processing/ophys/events|AnnotatedEventsTable

It would be great if neurosift can recognize event_times column in event tables (types: LabeledEvents, AnnotatedEventsTable) created by ndx-events for raster plots

@magland
Copy link
Collaborator

magland commented Jul 31, 2023

Hi @tuanpham96

Is there a dandiset that has this data type? That would make it easy for me to develop against. Otherwise, is there a way you can send me an example .nwb file for this feature?

@bendichter

@tuanpham96
Copy link
Author

I'm not certain whether there's an existing dandiset for this yet. Maybe @bendichter knows.

Here's an example NWB file I generated from modifying the example from ndx-events README

ndx-events-example.zip

@magland
Copy link
Collaborator

magland commented Aug 1, 2023

@tuanpham96

AnnotatedEventsTable is now supported.

You should now see the following:

Image

which allows you to get two types of views

(a) A raster plot
(b) A table, with one row per unit

@magland
Copy link
Collaborator

magland commented Aug 1, 2023

Thanks @CodyCBakerPhD.

It appears that LabeledEvents does not have an event_times dataset. It has a timestamps dataset.

How would you expect LabeledEvents to be displayed? Raster plot with only one row?

@CodyCBakerPhD
Copy link
Contributor

It appears that LabeledEvents does not have an event_times dataset. It has a timestamps dataset.

LabeledEvents have data (non-unique integers indexing the labels), labels (list of unique strings), and timestamps (equal to the length of data)

https://pypi.org/project/ndx-events/

How would you expect LabeledEvents to be displayed? Raster plot with only one row?

I'd say a general strategy for this would be a raster whose number of 'units' (columns or Y axis) is the number of unique labels

@tuanpham96
Copy link
Author

tuanpham96 commented Aug 2, 2023

@magland thanks for this! I tested and it looks fine for the AnnotatedEventsTable for the time being. It'd be great to also support LabeledEvents as well, but since you already opened another issue., should I close this one?

@magland
Copy link
Collaborator

magland commented Aug 2, 2023

Glad that's working. Yes, I'll close this issue and we can follow up with #92.

@magland magland closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants