Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VrmImmo Crawler #467

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Add VrmImmo Crawler #467

merged 1 commit into from
Sep 9, 2023

Conversation

mrclrchtr
Copy link

I have just implemented the crawler for https://vrm-immo.de for my own purposes.
Maybe it can help someone else.

@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:30 — with GitHub Actions Inactive
@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:30 — with GitHub Actions Inactive
@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:30 — with GitHub Actions Inactive
@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:30 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #467 (099e377) into main (0e099b9) will increase coverage by 0.41%.
Report is 1 commits behind head on main.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   66.04%   66.46%   +0.41%     
==========================================
  Files          40       41       +1     
  Lines        2215     2260      +45     
  Branches      311      312       +1     
==========================================
+ Hits         1463     1502      +39     
- Misses        658      664       +6     
  Partials       94       94              
Files Changed Coverage Δ
flathunter/crawler/vrmimmo.py 86.36% <86.36%> (ø)
flathunter/config.py 60.36% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:33 — with GitHub Actions Inactive
@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:33 — with GitHub Actions Inactive
@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:33 — with GitHub Actions Inactive
@mrclrchtr mrclrchtr temporarily deployed to test September 9, 2023 11:33 — with GitHub Actions Inactive
Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks so much for the new crawler, and for the tests!

I see this try: except: pattern in the other crawlers too for extracting elements from the soup, and I wonder if there would be a more elegant way here (either a utility function, or a library wrapper). But maybe that's a fun refactor for me some time when I have too little to do :)

@codders codders merged commit 4ef7192 into flathunters:main Sep 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants