Add some typehints

flack · Aug 1, 2024 · 3c26bee · 3c26bee
1 parent 34c53e3
commit 3c26bee
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/midcom/admin/folder/handler/order.php b/lib/midcom/admin/folder/handler/order.php
@@ -7,6 +7,7 @@
  */
 
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 
 /**
  * Sort navigation order.
@@ -22,7 +23,7 @@ class midcom_admin_folder_handler_order extends midcom_baseclasses_components_ha
     /**
      * Set the score.
      */
-    private function _process_order_form(Request $request)
+    private function _process_order_form(Request $request) : ?Response
     {
         // Form has been handled if cancel has been pressed
         if ($request->request->has('f_cancel')) {
@@ -32,7 +33,7 @@ private function _process_order_form(Request $request)
 
         // If the actual score list hasn't been posted, return
         if (!$request->request->has('f_submit')) {
-            return;
+            return null;
         }
 
         if ($request->request->has('f_navorder')) {

diff --git a/lib/midcom/baseclasses/components/handler/dataexport.php b/lib/midcom/baseclasses/components/handler/dataexport.php
@@ -219,7 +219,7 @@ private function _init_csv_variables(Request $request)
         }
     }
 
-    private function encode_csv(string $data)
+    private function encode_csv(string $data) : string
     {
         /* START: Quick'n'Dirty on-the-fly charset conversion */
         if ($this->csv['charset'] !== 'UTF-8') {

diff --git a/lib/midcom/connection.php b/lib/midcom/connection.php
@@ -107,7 +107,7 @@ public static function verify_password(string $password, string $hash) : bool
         return $password === $hash;
     }
 
-    public static function prepare_password(string $password)
+    public static function prepare_password(string $password) : string
     {
         if (midcom::get()->config->get('auth_type') == 'Legacy') {
             return password_hash($password, PASSWORD_DEFAULT);