New rpc calls for mobile #1449
New rpc calls for mobile #1449
Conversation
WalkthroughThe recent changes encompass various enhancements to the RPC methods and the handling of transaction hashes within the blockchain. Key updates include new RPC commands for retrieving mempool transaction IDs and tags, modifications to the Changes
Sequence Diagrams
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- src/chain.h (3 hunks)
- src/rpc/client.cpp (1 hunks)
- src/rpc/misc.cpp (3 hunks)
- src/rpc/server.cpp (1 hunks)
- src/rpc/server.h (1 hunks)
- src/spark/state.cpp (5 hunks)
- src/spark/state.h (4 hunks)
- src/txdb.cpp (1 hunks)
Files skipped from review due to trivial changes (1)
- src/rpc/client.cpp
Additional comments not posted (17)
src/rpc/server.h (3)
219-219: The declaration ofgetusedcoinstagstxhashesis correctly added.
221-221: The declaration ofgetmempooltxidsis correctly added.
222-222: The declaration ofgetmempooltxsis correctly added.src/spark/state.h (3)
29-29: The addition ofltagTxhashmember inCSparkStateis correctly implemented to store linking tag hashes mapped to transaction hashes.
172-172: The addition ofAddLTagTxHashmethod inCSparkStateis correctly implemented to handle the insertion of linking tag hashes.
218-218: The addition ofGetSpendTxIdsmethod inCSparkStateis correctly implemented to retrieve linking tag hashes.src/rpc/server.cpp (3)
345-345: The addition ofgetusedcoinstagstxhashescommand in the mobile category is correctly implemented.
347-347: The addition ofgetmempooltxidscommand in the mobile category is correctly implemented.
348-348: The addition ofgetmempooltxscommand in the mobile category is correctly implemented.src/chain.h (2)
264-265: The addition ofltagTxhashtoCBlockIndexis well-implemented. Ensure that the hash map is used securely and efficiently.
308-308: ClearingltagTxhashin theSetNullmethod is a good practice to ensure that the object starts with a clean state.src/txdb.cpp (1)
428-428: The assignment ofltagTxhashfromdiskindextopindexNewensures that the transaction hash map is correctly loaded into the block index. This is crucial for the new RPC functionalities introduced in the PR.Verification successful
The
ltagTxhashis correctly utilized insrc/rpc/misc.cppfor mapping transaction IDs, which aligns with the intended functionality. The assignment insrc/txdb.cppensures that this mapping is correctly loaded into the block index.
src/rpc/misc.cpp: std::unordered_map<uint256, uint256> ltagTxhash;src/rpc/misc.cpp: ltagTxhash = sparkState->GetSpendTxIds();src/rpc/misc.cpp: if (ltagTxhash.count(ltagHash) > 0)src/rpc/misc.cpp: txid = ltagTxhash[ltagHash];Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `ltagTxhash` is correctly utilized in the new RPC methods. # Test: Search for the usage of `ltagTxhash` in the new RPC methods. Expect: Proper handling and no errors. rg --type cpp $'ltagTxhash' src/rpc/Length of output: 291
src/spark/state.cpp (5)
268-277: The handling of-mobileflag for conditional execution is consistent across the codebase.
1090-1094: The conditional logic for handling the-mobileflag during block addition is implemented correctly. This ensures that mobile-specific data is handled appropriately based on runtime configuration.
1341-1343: The methodGetSpendTxIdsprovides a consistent interface to accessltagTxhash. This is a good practice as it encapsulates the data structure, allowing for easier maintenance and potential future changes.
1050-1052: The methodAddLTagTxHashis added to handle the insertion of tag-hash pairs intoltagTxhash. Ensure that this method is used consistently whereverltagTxhashis modified.Verification successful
The search results indicate only one direct modification to
ltagTxhash, which is within theAddLTagTxHashmethod itself. This confirms that the method is used consistently for modifyingltagTxhash.
src/spark/state.cpp: The direct modification found is within theAddLTagTxHashmethod.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of `AddLTagTxHash` method across the codebase. # Test: Search for direct modifications to `ltagTxhash` that bypass `AddLTagTxHash`. rg --type cpp $'ltagTxhash\[.*\] ='Length of output: 91
702-704: The conditional insertion ofltagTxhashbased on the-mobileflag is implemented correctly. However, ensure that the functionprimitives::GetLTagHashis robust and handles edge cases effectively.
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/rpc/misc.cpp (3 hunks)
Additional comments not posted (1)
src/rpc/misc.cpp (1)
1510-1588: The implementation ofgetmempooltxsappears to be correct, but ensure that the method is thoroughly tested, especially the parsing and handling of transaction data.
|
@psolstice the description added. |
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/rpc/misc.cpp (3 hunks)
- src/rpc/server.cpp (1 hunks)
- src/rpc/server.h (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/rpc/server.cpp
Additional comments not posted (4)
src/rpc/server.h (1)
221-221: Ensure consistency in naming and functionality forgetmempoolsparktxids.This function is supposed to return all spark transaction IDs currently in the mempool. Verify its implementation in
src/rpc/misc.cppto ensure it aligns with the naming conventions and functionality described.Verification successful
The
getmempoolsparktxidsfunction insrc/rpc/misc.cppis correctly implemented to return all spark transaction IDs currently in the mempool. It checks for help requests or incorrect parameters, retrieves all transactions from the mempool, filters for spark transactions, and returns their IDs.
- The function name
getmempoolsparktxidsaccurately reflects its functionality.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for the implementation of `getmempoolsparktxids` in `src/rpc/misc.cpp` fd "misc.cpp" src/rpc/ --exec cat {} | grep -A 3 -B 3 "getmempoolsparktxids"Length of output: 904
Script:
#!/bin/bash # Retrieve the full implementation of the `getmempoolsparktxids` function in `src/rpc/misc.cpp` ast-grep --lang cpp --pattern 'UniValue getmempoolsparktxids(const JSONRPCRequest& request) { $$$ }' src/rpc/misc.cppLength of output: 119
Script:
#!/bin/bash # Reattempt to retrieve the full implementation of the `getmempoolsparktxids` function in `src/rpc/misc.cpp` rg -A 20 -B 5 'UniValue getmempoolsparktxids' src/rpc/misc.cppLength of output: 769
src/rpc/misc.cpp (3)
1407-1462: Exception handling forstd::stolis correctly implemented, ensuring robust input validation.
1491-1508: Proper implementation ofgetmempoolsparktxidsto retrieve Spark transaction IDs from the mempool.
1510-1588: Consider clarifying the RPC help description forgetmempoolsparktxsto better explain the expected input and output data formats.
[ISSU- "\nReturns spark data for each transaction.\n" + "\nReturns detailed Spark transaction data for each specified transaction ID.\n"
| @@ -216,7 +216,10 @@ extern UniValue getlatestcoinid(const JSONRPCRequest& params); | |||
| extern UniValue getsparkanonymityset(const JSONRPCRequest& params); | |||
| extern UniValue getsparkmintmetadata(const JSONRPCRequest& params); | |||
| extern UniValue getusedcoinstags(const JSONRPCRequest& params); | |||
| extern UniValue getusedcoinstagstxhashes(const JSONRPCRequest& params); | |||
There was a problem hiding this comment.
Add documentation for getusedcoinstagstxhashes.
The function getusedcoinstagstxhashes is introduced to extend the functionality of the existing getusedcoinstags by also providing the transaction hash in which the coin was spent. It's crucial to have proper documentation for new RPC methods to ensure they are used correctly and understood by other developers or API consumers.
Added new rpc calls,
getusedcoinstagstxhashes, this rpc returns all spent coin serials attached to the hash of spending transaction, previously we hadgetusedcoinstags, the new call allows to get also in which transaction is spent the coin, to do this we add field inside block index, and in spark state, when tx is being checked during block acceptance, we add the pair of ltag and tx hash into block index, and each time we construct the state, we get the data from the index. this fields are constructed in case-mobileis passed,getmempooltxidsgives the list of spark tx hashes inside mempool, this allow to get spark state not only for blockchian but also from mempool.getmempooltxsreturns spark metadata for each tx hash, existing in mempool, in case there is no data for particular tx, that means tx is removed from mempool, confirmed or removed for another reason.