Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos git action build fix #1435

Merged
merged 2 commits into from
May 2, 2024
Merged

Macos git action build fix #1435

merged 2 commits into from
May 2, 2024

Conversation

levoncrypto
Copy link
Contributor

@levoncrypto levoncrypto commented Apr 27, 2024

Summary by CodeRabbit

  • Chores
    • Updated the installation process to include additional required packages for better compatibility and performance.

Copy link

coderabbitai bot commented Apr 27, 2024

Walkthrough

The recent modifications streamline the installation and configuration process in the CI workflow for a project. Key updates include the addition of python-setuptools to the Homebrew installation list and an adjustment in the ./configure command to better accommodate dynamic directory paths based on the system's architecture.

Changes

File Change Summary
.github/workflows/.../ci-master.yml - Added python-setuptools to Homebrew installs
- Modified ./configure command to use dynamic path

Poem

🐇✨
In the realm of code, where the bits align,
A rabbit hopped through, making changes fine.
With a tweak and a hop, setups refined,
Now smoother than ever, as paths intertwined.
Cheers to the craft, with each line we bind! 🎉
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between faac9c7 and c52c209.
Files selected for processing (1)
  • .github/workflows/ci-master.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci-master.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -181,7 +181,7 @@ jobs:
working-directory: ${{ env.SOURCE_ARTIFACT }}
- name: Build Firo
run: |
./configure --disable-jni --prefix=$(grealpath depends/x86_64-apple-darwin*)
./configure --prefix=`pwd`/depends/`depends/config.guess`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure it's used on mac only. This option can wreak havoc if used when cross-compiling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psolstice Тhis configuration is used only for Mac, for the rest there are separate config. Thank you)

@justanwar justanwar merged commit 7fb07bf into master May 2, 2024
6 checks passed
@justanwar justanwar deleted the actions_update branch May 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants