buildroot perf support #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Committing compiled objects into this repo makes me nervous. What happens if we bump the kernel? How would we update this? |
|
That is a good point. But we don't really update that often :) |
But we shouldn't make it harder for ourselves to upgrade.... |
There was a problem hiding this comment.
Whats the current way to add perf to buildroot? Isn't it just setting BR2_PACKAGE_PERF? We can just set that as the default and upload a br-image for that? I agree with Jerry, uploading artifacts of a build IMO isn't clean... even assuming it was there is no script to generate the files when bumping again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a example workload that copies the
perfbinary and the corresponding dynamically linked libraries into the br image.This is a workaround as adding a buildroot perf package requires us to use the buildroot kernel.