Skip to content

Commit

Permalink
refactor: Improve validation logic in Item class (#120)
Browse files Browse the repository at this point in the history
  • Loading branch information
kadirkaang authored Sep 2, 2024
1 parent 282e65b commit a53344f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions vscode/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ All notable changes to the "dependi" extension will be documented in this file.
- CHANGELOG cleanup and formatting.
- Notification for dependi updates now has a beaituful CHANGELOG view.

### Bug Fixes

- Fixed issue with `*` version not showing package versions. [Issue 118](https://github.com/filllabs/dependi/issues/118)

## [v0.7.8](https://github.com/filllabs/dependi/compare/v0.7.7...v0.7.8)

### New Features
Expand Down
2 changes: 1 addition & 1 deletion vscode/src/core/Item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,6 @@ export default class Item {
}

isValid() {
return this.key.length > 0 && this.value?.length && this.start > -1 && this.end > -1 && /\d/.test(this.value);
return this.key.length > 0 && this.value?.length && this.start > -1 && this.end > -1 && (/\d/.test(this.value) || this.value === "*");
}
}

0 comments on commit a53344f

Please sign in to comment.