Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new test to fix issue #628 #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Jan 25, 2019

This change adds a test to fix the case that the data we send to writeFile is a Number vs. a String of Buffer.

@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #673 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   86.71%   86.76%   +0.05%     
==========================================
  Files          16       16              
  Lines        1746     1746              
==========================================
+ Hits         1514     1515       +1     
+ Misses        232      231       -1
Impacted Files Coverage Δ
src/filesystem/implementation.js 83.81% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...0092614. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants