Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity that the dashboard is loading data and not broken #52

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Improve clarity that the dashboard is loading data and not broken #52

merged 1 commit into from
Aug 14, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 8, 2023

What does this PR do?

  • It improves clarity that the dashboard is loading data and not broken

Issue reference

Demo video/scrennshot:

@gitstart
Copy link
Contributor Author

gitstart commented Aug 8, 2023

@guanzo @joaosa @DiegoRBaquero this PR is ready for review

@gitstart
Copy link
Contributor Author

gitstart commented Aug 9, 2023

Hello nice to meet you. We are GitStart building a service for engineering teams to assign tickets and get back PRs. We'd appreciate if you'd read our PR.
If at first glance it doesn't look at all like something you'd merge, please simply send us a "nope" and we'll figure out why ourselves with the help of our mentors. Our goal is for you not to spend time on totally off-road PRs.
However if the PR interests you, please proceed like you always do.
You can always reach us via [email protected] for any feedback or questions. Thank you!

@guanzo
Copy link
Collaborator

guanzo commented Aug 9, 2023

On the top right chart, "No Rows To Show" should be replaced with a loading spinner when it's loading.

The top left chart looks a bit weird because the loading icon is off center. My suggestion is to hide the text while loading, and put the loading icon in the center. When it's done loading, make the text visible again.

Basically, all charts should look similar while loading, mainly the loading icon should be centered.

@gitstart
Copy link
Contributor Author

On the top right chart, "No Rows To Show" should be replaced with a loading spinner when it's loading.

The top left chart looks a bit weird because the loading icon is off center. My suggestion is to hide the text while loading, and put the loading icon in the center. When it's done loading, make the text visible again.

Basically, all charts should look similar while loading, mainly the loading icon should be centered.

We're on it

@gitstart
Copy link
Contributor Author

On the top right chart, "No Rows To Show" should be replaced with a loading spinner when it's loading.

The top left chart looks a bit weird because the loading icon is off center. My suggestion is to hide the text while loading, and put the loading icon in the center. When it's done loading, make the text visible again.

Basically, all charts should look similar while loading, mainly the loading icon should be centered.

Loom video for the new updates pushed https://www.loom.com/share/f6860500e0f1420dbf54be274f7efea5?sid=471fe11e-2497-4e3d-9619-a85b6065c3a4

@guanzo guanzo merged commit e67bbf9 into filecoin-saturn:main Aug 14, 2023
10 checks passed
@guanzo
Copy link
Collaborator

guanzo commented Aug 14, 2023

looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants