docs: update network skeleton docs based on nv24 learnings #12524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
This includes some followups/learnings #12481.
BigLep
commented
Sep 27, 2024
There was a problem hiding this comment.
@rjan90 : I left some comments explaining my intent here.
Thinking about the feedback from #12481 , reviewing what was done for nv24, and writing this PR helped me catch some extra things in the network upgrade. I also did some related updates in the network upgrade template (https://docs.google.com/document/d/1KKJj2COb0vIqAQh-4F7fflJjxiTgGrU9oT9B461nsgg/edit ). Sorry I've been slow not to catch some of these things sooner.
8 tasks
rjan90
approved these changes
Sep 30, 2024
3 tasks
Base automatically changed from
biglep/document-lotus-dependency-versions
to
master
September 30, 2024 14:58
BigLep
commented
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some followups/learnings #12481, particularly around the filecoin-ffi dependency on go-state-types. This PR is currently targeting that PR.
Some udpates were also made to the network upgrade template: https://docs.google.com/document/d/1KKJj2COb0vIqAQh-4F7fflJjxiTgGrU9oT9B461nsgg/edit
Checklist
Before you mark the PR ready for review, please make sure that: