Make aggregation retries more granular #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperzuk-neti
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
force-pushed
the
more-granular-retries
branch
from
51281ca
to
1023f05
Compare
kacperzuk-neti
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
force-pushed
the
more-granular-retries
branch
from
1023f05
to
a2585e3
Compare
kacperzuk-neti
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
force-pushed
the
more-granular-retries
branch
from
a2585e3
to
2ffd5cf
Compare
kacperzuk-neti
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
force-pushed
the
more-granular-retries
branch
from
2ffd5cf
to
ff32939
Compare
kacperzuk-neti
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
force-pushed
the
more-granular-retries
branch
from
ff32939
to
d5c734c
Compare
kacperzuk-neti
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
neti-mateusz-mazur
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach of retrying whole set of aggregations from scratch doesn't really work. It retries and just fails again after the same amount of time on the retry.
Additionally, looks like immediately retrying doesn't give enough time for primary server to process everything and next cancel comes very soon. Adding a 30s wait fixes that.