Add changelog appendix #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
pietroalbini
requested changes
Jul 4, 2024
|
|
||
| * `Rework \`impl Trait\` lifetime inference <https://github.com/rust-lang/rust/pull/116891/>`_ | ||
|
|
||
| * No change: capturing of lifestime within ``impl Trait`` types is not described in the FLS |
There was a problem hiding this comment.
This feels like a gap in the FLS we should fill (and describe).
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
pietroalbini
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Marking Lukas's changes as approved, waiting for Lukas to approve my changes before we merge this.
I think the best thing is to merge this PR right now, and tackle the three points I mentioned in #511 (review) in followup PRs that both fix the points and update the changelog.
|
bors merge |
|
Build succeeded: |
This was referenced Jul 5, 2024
bors-ferrocene bot
added a commit
that referenced
this pull request
Jul 8, 2024
513: Specify auto trait trait object upcasting r=pietroalbini a=Veykril #511 (comment) Co-authored-by: Lukas Wirth <[email protected]>
bors-ferrocene bot
added a commit
that referenced
this pull request
Jul 8, 2024
512: Add library crate definition back r=pietroalbini a=Veykril #511 (comment) Co-authored-by: Lukas Wirth <[email protected]> Co-authored-by: Pietro Albini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.