[Factors] Integrate llm factor #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
commented
Aug 22, 2024
lann
approved these changes
Aug 22, 2024
| spin-factors = { path = "../factors" } | ||
| spin-llm-local = { path = "../llm-local" } |
There was a problem hiding this comment.
There are feature flags in the root spin-cli and old spin-trigger and spin-trigger-http crates that control dependencies for this.
There was a problem hiding this comment.
I'm going to do some small refactorings in a follow up that will make this easier to bring back.
Comment on lines
20
to
+21
| pub struct LlmFactor { | ||
| create_engine: Box<dyn Fn() -> Box<dyn LlmEngine> + Send + Sync>, | ||
| default_engine_creator: Box<dyn LlmEngineCreator>, |
There was a problem hiding this comment.
Out of scope for this PR but I'd like to standardize on the approach used with e.g. OutboundMysqlFactor<C = MysqlClient> for this sort of thing.
There was a problem hiding this comment.
Yea, I'd personally like to move away from generics and towards using dynamic dispatch like we do here.
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
integrate-llm-factor
branch
from
086a6b2
to
a7c9163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the LLM factor into trigger2.
I don't really love how the
use_gpuconfiguration item (which for now is hardcoded as true) is being weaved through out the code, but I'd rather go back in a follow up PR to try to clean up how we handle configuration in some holistic way.