Make VariablesFactor non-generic
#2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
ungeneric-variables
branch
from
63e00bd
to
8fed097
Compare
Similar to #2687 (comment) I think this indicates that we need to add functionality to the factors interface. |
lann
approved these changes
Jul 29, 2024
| /// The runtime configuration for the variables factor. | ||
| #[derive(Default)] | ||
| pub struct RuntimeConfig { | ||
| pub providers: Vec<Box<dyn Provider>>, |
There was a problem hiding this comment.
Probably better to hide this field behind a e.g. add_provider method.
There was a problem hiding this comment.
Good idea. I'll make this change in a follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2687 but for variables.
This does change that embedders no longer need to register the supported providers before hand. Which providers are supported and which aren't is all contained within the implementation of
FactorRuntimeConfigSource<VariablesFactor>.I also moved the host implementation to its own module like many other factors already have.