Remove assumption of toml in variables factor #2676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
rylev
commented
Jul 23, 2024
| @@ -31,7 +31,7 @@ async fn disallowed_host_fails() -> anyhow::Result<()> { | |||
| networking: OutboundNetworkingFactor, | |||
| pg: OutboundPgFactor, | |||
| }; | |||
| factors.variables.add_provider_type(StaticVariables)?; | |||
| factors.variables.add_provider_resolver(StaticVariables)?; | |||
There was a problem hiding this comment.
We're using resolver for two types of resolution now: variable resolution and runtime config resolution. Both of these usages have precedence in other places so it's hard to make an argument for getting rid of one or the other. I personally don't find it confusing, but I've also been staring at this code for a while...
There was a problem hiding this comment.
I would be in favor of using a different name here even if it's a little less obvious than "resolver".
Maybe we could pick a name for this general pattern of delegating from a factor to one of several impls like "subfactors"?
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
|
Closed in favor of #2685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors other factors in that it is not tied to a specific layout in toml for runtime configuration.