spin-kv-memcached: init #2405
Draft
spin-kv-memcached: init #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a memcached backing implementation for Spin KV. Picked the backing lib mostly based on it already having a connection pool and semi-acceptable code coverage (https://github.com/aisk/rust-memcache) - it's missing any kind of built-in async-io, but that is probably fine.
Currently still a little WIP (need to finish up an "exists" implementation but I'm going to do that when I'm back next week, a hacky
getbased one was enough to unblock my personal side project needs).Also need to learn how to use the new e2e test suite to have this hit real memcached for tests.