Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Levick <[email protected]>
  • Loading branch information
rylev committed Oct 18, 2023
1 parent fb84de2 commit 8d30055
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion crates/outbound-mysql/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl v2::HostConnection for OutboundMysql {
.await
.map_err(|e| v2::Error::ConnectionFailed(format!("{e:?}")))?,
)
.map_err(|_| v2::Error::Other("too many connections".into()))
.map_err(|_| v2::Error::ConnectionFailed("too many connections".into()))
.map(Resource::new_own)
}
.await)
Expand Down
2 changes: 1 addition & 1 deletion crates/outbound-pg/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ impl v2::HostConnection for OutboundPg {
.await
.map_err(|e| v2::Error::ConnectionFailed(format!("{e:?}")))?,
)
.map_err(|_| v2::Error::Other("too many connections".into()))
.map_err(|_| v2::Error::ConnectionFailed("too many connections".into()))
.map(Resource::new_own)
}
.await)
Expand Down
6 changes: 3 additions & 3 deletions wit/preview2/mysql.wit
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
interface mysql {
use fermyon:spin/rdbms-types.{parameter-value, row-set}

/// Errors related to interacting with Mysql.
/// Errors related to interacting with MySQL.
variant error {
connection-failed(string),
bad-parameter(string),
Expand All @@ -10,9 +10,9 @@ interface mysql {
other(string)
}

/// A connection to a mysql database.
/// A connection to a MySQL database.
resource connection {
/// Open a connection to the Postgres instance at `address`.
/// Open a connection to the MySQL instance at `address`.
open: static func(address: string) -> result<connection, error>

/// query the database: select
Expand Down

0 comments on commit 8d30055

Please sign in to comment.