Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Intellisense autocomplete also suggests private or protected met… #681

Closed
wants to merge 7 commits into from
Closed

Conversation

gnoe
Copy link

@gnoe gnoe commented Nov 9, 2018

Checking the visibility and the context from where the node is: inside a method declaration or after an instantiation

…hod and properties

Checking the visibility and the context from where the node is: inside a method declaration or after an instantiation
@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #681 into master will increase coverage by 0.07%.
The diff coverage is 93.33%.

@@             Coverage Diff              @@
##             master     #681      +/-   ##
============================================
+ Coverage     81.83%   81.91%   +0.07%     
- Complexity      883      892       +9     
============================================
  Files            44       44              
  Lines          1993     2007      +14     
============================================
+ Hits           1631     1644      +13     
- Misses          362      363       +1
Impacted Files Coverage Δ Complexity Δ
src/CompletionProvider.php 94.61% <100%> (+0.09%) 109 <0> (+1) ⬆️
src/Definition.php 95.65% <90.9%> (-4.35%) 14 <8> (+8)

@felixfbecker
Copy link
Owner

Closing in favor of #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants