Allow winbind_rpcd_t processes access when samba_export_all_* is on #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit expand the commit 7367896 to include winbind_rpcd_t process to access all samba shares when boolean samba_export_all_rw or samba_export_all_ro is enabled. Signed-off-by: Lukas Vrabec <[email protected]>
|
Cockpit tests failed for commit 1afd012. @martinpitt, @jelly, @mvollmer please check. |
|
Sorry about the revdeps/rawhide failure, I'll look into it. Not related to this update. It's the same TF troubles as in #1870 (comment) and I sent cockpit-project/cockpit#19547 to work around it. After that lands, tests can be retried here. |
|
LGTM |
|
cockpit-project/cockpit#19547 landed, so if you want you can retry that rawhide:revdeps test (I can't, as I am not a project owner). update: I got added to the team, I can retry them myself now. Done. |
|
Merging, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit expand the commit 7367896 to include winbind_rpcd_t process to access all samba shares when boolean samba_export_all_rw or samba_export_all_ro is enabled.