Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gamepad icon #760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add gamepad icon #760

wants to merge 1 commit into from

Conversation

awgv
Copy link

@awgv awgv commented Oct 7, 2019

Closes #469. In case you want to also check the duplicates, #469 is a duplicate of #120 that already has a PR attached to it (#134). Some things to mention:

  1. 2x2 buttons are lines with .01 length like in Fix dots in Figma #728.
  2. Since the icon’s shape is narrow, I had to stretch it into the “safe zone” to preserve the optical volume.

In general, gamepads have shapes that are too complex for 24x24 canvases. I think that Google made a good choice by picking the Nintendo Entertainment System controller for Material icons, because not only it’s an iconic object, it’s simple enough to be replicated as an icon, so I did the same for Feather.

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #760 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #760   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffce177...7d4a5e2. Read the comment docs.

Copy link

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@moeenio moeenio mentioned this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Game Controller
2 participants