Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hecs to upstream 0.7 #533

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Plecra
Copy link

@Plecra Plecra commented Feb 8, 2022

Status

  • Ready
  • Development
  • Hold

Description

I have bumped the hecs version to 0.7, and removed the dependency on the git version.

This mostly involved small changes to compensate for Entity::from_bits being fallible now. The biggest change was reimplementing the DynamicQuery logic (from feather-rs/feather-hecs@87d8d00) in-tree.

The new implementation should behave identically to the old code, with a couple small optimizations. There is room for more optimization too :) This is the change that I hope someone can fully review

Related issues

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant