Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NodePosY argument to sankeyNetwork.R to control y position of nodes #21

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

atarashansky
Copy link

It was not clear to me what form the yOrderComparator argument should take in pull request #16 so I added a NodePosY argument to sankeyNetwork to allow the user to directly specify the y position of nodes.

@todd-davidson-beis
Copy link

todd-davidson-beis commented Jun 12, 2023

So I know this package hasn't been updated in a while, but I just wanted to recommend this PR - really useful and simple functionality (just give a value to each node and it will sort them into order - the values themselves are immaterial) for fixing the vertical order of nodes. I've found it particularly powerful if also fixing PosX when making repeatable figures for publications.

(Though installing it does not seem to work for me - I can install the package (using a zip of the repo and devtools::install_local ) which sets up all the javascript bits, but the main sankeyD3::sankeyNetwork function does not then recognise the NodePosY argument - so I had to directly source the sankeyNetwork.R script and utils.R script, unfortunately, but then it all works!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants