Warn about missing coverage information and SkunkScore impact #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 81.93% 82.29% +0.35%
==========================================
Files 19 19
Lines 299 305 +6
==========================================
+ Hits 245 251 +6
Misses 54 54
Continue to review full report at Codecov.
|
| @@ -41,7 +41,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency "rubycritic", ">= 4.4", "< 5.0" | |||
| spec.add_dependency "terminal-table", "~> 1.8.0" | |||
|
|
|||
| spec.add_development_dependency "bundler", "~> 2.0" | |||
There was a problem hiding this comment.
Why we dropping the bundler dependency?
There was a problem hiding this comment.
The main reason was because Travis wasn't building, check it out here:
https://travis-ci.org/github/fastruby/skunk/builds/728404194
Then there's the question about if bundler is a development dependency of Skunk which I intuitively thought it isn't.
Honestly I'm not sure what the usual pattern is and if there's a reason why one would specify Bundler as a dep for a project.
| codeclimate-engine-rb (0.4.1) | ||
| virtus (~> 1.0) | ||
| codecov (0.1.16) |
There was a problem hiding this comment.
codecov 0.1.16 was yanked, that's why we needed to update here.
Check:
https://rubygems.org/gems/codecov/versions
Fixes #25