Update for missing name and add tests

[FionaDL]

Jira Ticket

DT-455

Motivation / Context

#318 This fixes this issue.
If anyone on the team didn't have a name in Github no name was being saved that user and it was causing issues if a user was attached to a story through an estimation. Updated so that any time there isn't a name we can fall back on the email so we won't have this issue anywhere again in the future. Also added a test to make sure this was working.

QA / Testing Instructions

Try adding changing a user in the test db to not have a name and make sure madmin still works.
Follow the steps in issue #318 to make sure it is still fixed.

Screenshots:

---

I will abide by the code of conduct.

[JuanVqz]

is the email required/validated to be present? what if the email is nil?

[etagwerker]

@JuanVqz Users come from GitHub and we always collect their email address. So there is no way for the email to be nil.

@FionaDL On the other hand, this doesn't look very straightforward, why do we need the call to read_attribute?

I would recommend two different alternatives:

Suggested change

	read_attribute(:name) || email
	name || email

Or:

Suggested change

	read_attribute(:name) || email
	name.presence || email

[FionaDL]

@etagwerker I tested with your suggestions, but I think it is creating an infinite loop, I get "stack level too deep (SystemStackError)".

I think we could do self[:name] || email if it feels more straightforward. What do you think?

[etagwerker]

@FionaDL Oh, I understand why that would do that.

How about this instead?

  def name_or_email
    name || email
  end

[FionaDL]

@etagwerker I could do that, but then we will have to be sure that name_or_email gets called everywhere that we would want to call user.name, right?

[etagwerker]

When it comes to presentation logic, I think it is usually best to have this sort of code in a view helper file.

So maybe it would be best to move this code to the application_helper file and later change the references in the view to this new method.

So yeah, that means that all view files that call user.name will now have to call something like display_name(user)

[FionaDL]

Hey @etagwerker I think I updated with what you are aiming towards.

[etagwerker]

@FionaDL I think this is very close. I think there is one last place to add this:

points/app/controllers/stories_controller.rb

Line 96 in c754fc7

comments << "#{comment.user.name}: #{comment.body}"

[etagwerker]

Looks good, thanks!