ROAD-546: Add comments to stories #304
Conversation
torresga
changed the title
torresga
changed the title
… with more than one comment
| @story = Story.find(params[:story_id]) | ||
| rescue ActiveRecord::RecordNotFound | ||
| flash[:error] = "Project or Story not found" | ||
| redirect_to projects_path |
There was a problem hiding this comment.
I wonder if we should handle the 2 possible exceptions individually, so in the cases where the project exists and the story doesn't we can redirect to the project instead of redirecting to the index
There was a problem hiding this comment.
I agree, but should we do that in this ticket or create another issue?
There was a problem hiding this comment.
I don't know, this is adding this code, we could create another story though, it's not a blocker so I'm fine ignoring it for now
| @story = Story.find(params[:story_id]) | ||
| rescue ActiveRecord::RecordNotFound | ||
| flash[:error] = "Project or Story not found" | ||
| redirect_to projects_path |
There was a problem hiding this comment.
I don't know, this is adding this code, we could create another story though, it's not a blocker so I'm fine ignoring it for now
There was a problem hiding this comment.
I think we need to make sure that importing the generated CSV works. As per Atlassian's docs, I believe that the comments will need to be quoted.
Then again, I'm assuming this has worked so far, so maybe nothing else is needed? Their documentation isn't super detailed as it should be, honestly. They mention how to format a comment and say that we can just put multiple comments in separate columns, but don't specify if each comment needs it's own header or if it will just assume that subsequent values are comments.
I believe we need @ABizzinotto to QA this last bit of the feature.
I'm approving the PR, but I believe we need to address the above before merging. Unless someone has tried it already
The CSV export compatible with JIRA is in a different story https://ombulabs.atlassian.net/browse/VLT-5 that was not worked on yet, that is not part of this PR |
ABizzinotto
added
Ready to Merge
Jira Ticket
Jira ticket associated with this PR
Motivation / Context
Context can be found in this issue: #195
Basically, this PR adds comments to Stories in Points. This is to help keep information together that usually ends up in other channels (such as Slack). The comments are also exportable. The comments don't end up in the action plan.
QA / Testing Instructions
Screenshots:
I will abide by the code of conduct.