Add Image Optimizer default settings API #516
Merged
Commits on May 14, 2024
-
-
-
Explicitly handle error 404 the API can return.
I'd forgotten about this case, but it's used when the user hasn't set any Image Optimizer settings, and it's useful for terraform to be able to easily detect this case. I assume other users of this API will also appreciate this explicit error handling, as opposed to having to check for error 404 themselves.
-
Make JpegType a constant, fix ResizeFilter values, and expand testing
Previously, ResizeFilter was missing a custom json marshalling function, and any request with a resize filter resulted in a server error. I've expanded testing to test all resize filter values, all jpeg type values, and to include a request which sends all possible keys - just to patch up any other missing untested parts.
-
-
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.