fix: check require.cache to find preloaded modules #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-michelet
commented
Jul 31, 2024
jean-michelet
commented
Jul 31, 2024
runtime.js
Outdated
| @@ -14,11 +16,16 @@ function checkProcessArgv (moduleName) { | |||
|
|
|||
| let preloadModules | |||
| function checkPreloadModules (moduleName) { | |||
| const modulePath = path.join(process.cwd(), 'node_modules/', moduleName) | |||
There was a problem hiding this comment.
Not sure about this path join.
I just want to do a startsWith instead of includes.
There was a problem hiding this comment.
Can process.cwd() guarantee to be the project root if the program is executed from other path?
There was a problem hiding this comment.
What would you do?
zetaraku
reviewed
Aug 1, 2024
|
|
||
| const modulePath = path.join(process.cwd(), 'node_modules', moduleName) | ||
| if (Object.keys(require.cache).some(k => k.startsWith(modulePath))) { | ||
| preloadModules.push(moduleName) |
There was a problem hiding this comment.
I still discourage mutating preloadModules, as you may mutate the process._preload_modules that may be used by others.
There was a problem hiding this comment.
zetaraku
reviewed
Aug 1, 2024
zetaraku
reviewed
Aug 1, 2024
climba03003
previously requested changes
Aug 1, 2024
climba03003
dismissed
their stale review
Nevermind, double checked it is not affected.
|
Thanks for opening a PR! Can you please add a unit test? |
|
Will try to make one later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
I tested on the reproduction repo and it does work well: https://github.com/zetaraku/fastify-app