Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 15_DDPM.ipynb #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 15_DDPM.ipynb #21

wants to merge 1 commit into from

Conversation

faisito
Copy link
Contributor

@faisito faisito commented Mar 15, 2023

(1) Breaking change
added super().init() to DDPMCB so that self.n_inp in TrainCB gets initialized (TrainCB changed after the lesson and this change makes DDPMCB consistent with the new version of TrainCB)

(2) Non-breaking change
deleted reference to global variable 'learn' because 'model' is already being passed to the method as a parameter, so, no need to refer to the global model

(1) Breaking change 
added super().__init__() to DDPMCB so that self.n_inp in TrainCB gets initialized (TrainCB changed after the lesson and this change makes DDPMCB consistent with the new version of TrainCB)

(2) Non-breaking change 
deleted reference to global variable 'learn' because 'model' is already being passed to the method as a parameter, so, no need to refer to the global model
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant