Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements made on Metrics file #408

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

gabrielademoraes
Copy link
Contributor

@gabrielademoraes gabrielademoraes commented Nov 26, 2019

Proposed Changes

In this PR, two methods were created intending to make the openMetrics method has single responsibility, because it was opening the metrics and deactivating the tablinks and tabcontents. #407

Type of Changes

  • Bugfix
  • New Feature

Checklist

  • This Pull Request has a significant name.
  • The build is okay (tests, code climate).
  • This Pull Request mentions a related issue.

Screenshots

refactoratedOpenMetricsMethod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant