Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(ci,pkg,cmd): bumped driverkit to v0.19.0. #44

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Apr 30, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build
/area cmd
/area pkg

What this PR does / why we need it:

Moreover, ported to use falcoctl logging library.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link

poiana commented Apr 30, 2024

@FedeDP: The label(s) kind/cleanup, area/build, area/cmd, area/pkg cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build
/area cmd
/area pkg

What this PR does / why we need it:

Moreover, ported to use falcoctl logging library.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator Author

FedeDP commented Apr 30, 2024

/hold

@poiana
Copy link

poiana commented Apr 30, 2024

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Moreover, ported to use falcoctl logging library.

Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP force-pushed the new/driverkit_0.19.0 branch 2 times, most recently from d523262 to 8e67662 Compare April 30, 2024 12:21
Also, fixed tests.

Signed-off-by: Federico Di Pierro <[email protected]>
@poiana
Copy link

poiana commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Collaborator Author

FedeDP commented May 2, 2024

/unhold

@poiana poiana merged commit cb3b85f into main May 2, 2024
4 checks passed
@poiana poiana deleted the new/driverkit_0.19.0 branch May 2, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants