Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sidekick chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created. #643

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kwop
Copy link
Contributor

@kwop kwop commented Mar 24, 2024

/kind bug

/kind chart-release

/area falcosidekick-chart

Prometheus does not accept duplicate rule name.

The chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created.

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels Mar 24, 2024
@poiana poiana requested review from alacuku and bencer March 24, 2024 12:57
@poiana
Copy link
Contributor

poiana commented Mar 24, 2024

Welcome @kwop! It looks like this is your first PR to falcosecurity/charts 🎉

@kwop kwop changed the title Patch 1 The chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created. Mar 24, 2024
@poiana poiana added the size/XS label Mar 24, 2024
@kwop kwop changed the title The chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created. The sidekick chart Prometheus rules can't be installed as is, leading to an error and preventing the resource to be created. Mar 24, 2024
@Issif
Copy link
Member

Issif commented Mar 25, 2024

Thanks for this fix, can you squash your commits please, I enabled the CI, all checks are ok.

@Issif
Copy link
Member

Issif commented Apr 26, 2024

Can you rebase on the master and fix the conflicts, please

Prometheus does not accept duplicate rule name.
The chart rule can't be installed.

Signed-off-by: Belazar Mohamed <[email protected]>

Update Chart.yaml

Bump chart version

Signed-off-by: Belazar Mohamed <[email protected]>

Update CHANGELOG.md

Signed-off-by: Belazar Mohamed <[email protected]>

Fix PrometheusRule duplicate alert name
@poiana
Copy link
Contributor

poiana commented Apr 30, 2024

LGTM label has been added.

Git tree hash: ba890ffd1dab5f0c99c44f5b5eb021db3e9cf6bd

@poiana
Copy link
Contributor

poiana commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, kwop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3799bd9 into falcosecurity:master Apr 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/falcosidekick-chart dco-signoff: yes kind/bug Something isn't working kind/chart-release Add this label when the chart version has been bumped lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants