Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(falco): chart for falco 0.37.0 #601

Merged
merged 19 commits into from
Jan 30, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jan 11, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

New chart for Falco 037.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review. This is awesome 🤩

I've just found some very minor issues (see comment below) and left some notes.

Also, please double check falco.yaml near to the release since some minor changes have been already introduced.

charts/falco/BREAKING-CHANGES.md Outdated Show resolved Hide resolved
charts/falco/BREAKING-CHANGES.md Outdated Show resolved Hide resolved
charts/falco/BREAKING-CHANGES.md Outdated Show resolved Hide resolved
charts/falco/BREAKING-CHANGES.md Outdated Show resolved Hide resolved
charts/falco/BREAKING-CHANGES.md Outdated Show resolved Hide resolved
charts/falco/values-k8saudit.yaml Outdated Show resolved Hide resolved
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific job 👏

I just left some comments and reminders (in particular, we are going to release falco-rules 3.0, then we will need to update the version here).

charts/falco/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/falco/templates/pod-template.tpl Show resolved Hide resolved
charts/falco/values-gvisor-gke.yaml Outdated Show resolved Hide resolved
charts/falco/values-gvisor-gke.yaml Outdated Show resolved Hide resolved
charts/falco/values-syscall-k8saudit.yaml Outdated Show resolved Hide resolved
charts/falco/values.yaml Outdated Show resolved Hide resolved
The defualt mode to get kubernetes metadata is using the
k8s-metacollector and the k8smeta plugin. This commit
adds the required helpers and variables to enable the
k8s-metacollector by default.

Signed-off-by: Aldo Lacuku <[email protected]>
@alacuku alacuku changed the title WIP: update(falco): chart for falco 0.37.0 update(falco): chart for falco 0.37.0 Jan 30, 2024
@alacuku
Copy link
Member Author

alacuku commented Jan 30, 2024

/hold until falco 0.37.0 is out.

@poiana
Copy link
Contributor

poiana commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 30, 2024

LGTM label has been added.

Git tree hash: 9d9abe1944ed09f4c5954dfef16b60834820c477

@leogr
Copy link
Member

leogr commented Jan 30, 2024

/hold cancel

@leogr
Copy link
Member

leogr commented Jan 30, 2024

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants