Issue #2648334 - Drag and drop reordering for actions/conditions #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not working.... Replaced rule actions table with drag and drop and trying to save weights on form submission, but not quite propagating changes to the entity yet. |
…ied up code style.
…ng in containers.
|
Just need to get some tests in now. I'm thinking KernelTest, but not sure how to test execution order... Maybe two actions that create nodes and then compare nids to check the order? |
|
@yanniboi is the tests what is missing? I ask because I could write them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mirrored on d.o here: https://www.drupal.org/node/2648334