Issue #2702127 by yanniboi: Active / Inactive toggle for rules #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns for reaction rules and updated event subscriber to only trigger active rules.
|
For screenshots see drupal.org issue. |
|
Added tests that make sure you are able to enable and disable rules and that disabled rules don't get triggered. |
|
Added the csrf tokens and manually tested install, works fine through the UI |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is mirrored on d.o by https://www.drupal.org/node/2702127.
I have exposed the config entity operations for enable and disable by adding link templates and added a Controller to handle them.
I have also added the 'active' checkbox to reaction rule settings and made sure that the event subscriber only triggers active rules.