Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add back BlockDiagonalMask import #1133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tanvitiwari-meta
Copy link

It looks like BlockDiagonalMask import was accidentally removed in commit 166fd2e. This commit adds it back.

What does this PR do?

Fixes # (issue).

Before submitting

  • [Yes] Did you have fun?
    • Make sure you had fun coding 🙃
  • [Yes] Did you read the contributor guideline?
  • [No] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • I work at Meta; I discussed this change with xformer maintainer over chat.
  • [No] Did you make sure to update the docs?
    • [V] N/A
  • [No] Did you write any new necessary tests?
    • [V] N/A
  • [No] Did you update the changelog? (if needed)
    • [V] N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2024
@bottler
Copy link
Contributor

bottler commented Oct 22, 2024

I think the change may have deliberate. It can be accessed as fmha.attn_bias.BlockDiagonalMask just like other attn_bias objects.

@danthe3rd
Copy link
Contributor

Apparently this is breaking some projects. So I'm fine with putting it back there.
However we need to fix the linter - let's just add it to the __all__ enumeration :)

Copy link
Contributor

@danthe3rd danthe3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like BlockDiagonalMask import was accidentally removed in commit 166fd2e.
This commit adds it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants