Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build rocm wheels #1081

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Build rocm wheels #1081

merged 2 commits into from
Aug 22, 2024

Conversation

tenpercent
Copy link
Contributor

@tenpercent tenpercent commented Aug 16, 2024 •
edited
Loading

This PR enables building ROCm xformers wheels, so they can be uploaded along the CUDA xformers wheels

Testing

Observe actions result

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm labels Aug 16, 2024
@tenpercent tenpercent force-pushed the rocm-wheels-upstream branch 4 times, most recently from 362e98e to 3752169 Compare August 19, 2024 17:01
@tenpercent tenpercent changed the title [Draft] build rocm wheels Build rocm wheels Aug 19, 2024
@tenpercent tenpercent marked this pull request as ready for review August 19, 2024 22:13
danthe3rd
danthe3rd reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@danthe3rd danthe3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but this looks good!

setup.py Outdated Show resolved Hide resolved
.github/workflows/rocm_wheels.yml Outdated Show resolved Hide resolved
.github/workflows/rocm_wheels.yml Outdated Show resolved Hide resolved
@tenpercent tenpercent force-pushed the rocm-wheels-upstream branch 6 times, most recently from 764536e to e29cd8c Compare August 21, 2024 16:14
danthe3rd
danthe3rd approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@danthe3rd danthe3rd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Will merge tomorrow when the tests are green

@danthe3rd danthe3rd merged commit e639746 into facebookresearch:main Aug 22, 2024
25 of 26 checks passed
@danthe3rd
Copy link
Contributor

danthe3rd commented Aug 22, 2024 •
edited
Loading

So the CI started running. It seems to build, but the workers time-out after 4h I think.
Here we see that after more than 2h, it has compiled less than half of it...
image

@tenpercent
Copy link
Contributor Author

So the CI started running. It seems to build, but the workers time-out after 4h I think. Here we see that after more than 2h, it has compiled less than half of it... image

It looks like we need 5-6 hours when there are 7 compile workers. E.g. https://github.com/facebookresearch/xformers/actions/runs/10503375692/job/29096625125 finished in 5h50m. Given there is a 6 hours timeout limit, we should probably increase it. I also see that the wheels skip uploading to s3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danthe3rd danthe3rd danthe3rd approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenpercent @danthe3rd @facebook-github-bot