Skip to content

Commit

Permalink
Fix deprecated dynamic exception in fbpcf/exception/exceptions.h +1 (#…
Browse files Browse the repository at this point in the history
…541)

Summary:
Pull Request resolved: #541

LLVM has detected a violation of `-Wdeprecated-dynamic-exception-spec`. Dynamic exceptions were removed in C++17. This diff fixes the deprecated instance(s).

See [Dynamic exception specification](https://en.cppreference.com/w/cpp/language/except_spec) and [noexcept specifier](https://en.cppreference.com/w/cpp/language/noexcept_spec).

Reviewed By: palmje

Differential Revision: D58182139

fbshipit-source-id: 23604f1d2732de4f94bf0b4bc157a2fe0111ba3b
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jun 5, 2024
1 parent 18a85f6 commit 98b4459
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fbpcf/exception/exceptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class ConnectionError : virtual public std::exception {
public:
explicit ConnectionError(std::string msg) : msg_{msg} {}

const char* what() const throw() override {
const char* what() const noexcept override {
return msg_.c_str();
}

Expand Down

0 comments on commit 98b4459

Please sign in to comment.