This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
update logging hook to report current best meter values #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D24880780 fbshipit-source-id: fbc151d016bdd8fdc2c67f896652d67c1a0a3bf9
Differential Revision: D21949491 fbshipit-source-id: 1c07006c97e801688f43949ab0cc1799bdcd6c55
Differential Revision: D23191690 fbshipit-source-id: 249ba98ecd6eb53682bf3f930edc0dc2a010da52
Differential Revision: D23261222 fbshipit-source-id: f360f779f4b17518c49a8a1c950f888536d8cea1
Differential Revision: D24881224 fbshipit-source-id: a507118503b8eef1bca06e9383bb73e434bb2818
Summary: For epoch-level meter, update the logging hook to maintain the max metrics and log them at the end of phase. Differential Revision: D24971237 fbshipit-source-id: 1ca3bde6e4723b6c89bb26a040e8ae48dac140af
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24971237 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For epoch-level meter, update the logging hook to maintain the max metrics and log them at the end of phase.
Differential Revision: D24971237