Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit configuration #206

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a pre-commit configuration #206

wants to merge 3 commits into from

Conversation

sajith
Copy link
Member

@sajith sajith commented Jul 24, 2023

Following up the discussion on #202, adding a pre-commit configuration. The way to use this would be with:

$ pip install pre-commit
$ pre-commit install 

With this, a git commit will trigger the checks defined in .pre-commit-config.yml. This way, black and isort checks will be done on the local setup. Instead of CI nagging us about formatting, a pre-commit check will nag us!

Perhaps this can be (optionally) combined with the third party pre-commit.ci service, if we want the formatting changes to be auto-applied on repository side.

@sajith sajith added the no changelog Causes to skip changelog checks in "checks" workflow label Jul 24, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2023

Pull Request Test Coverage Report for Build 5649506150

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 20.728%

Totals Coverage Status
Change from base Build 5647124708: 0.0%
Covered Lines: 927
Relevant Lines: 3998

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Causes to skip changelog checks in "checks" workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants