Fix warnings and android issues #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DreamNik
force-pushed
the
fix_warnings_and_android_issues
branch
3 times, most recently
from
bd96e0f
to
abe8a29
Compare
Android libraries can't be placed inside subdirectory, so to distinguish plugins from regular libraries the new prefix is used.
DreamNik
force-pushed
the
fix_warnings_and_android_issues
branch
from
abe8a29
to
b0e9193
Compare
|
|
Sorry this breaks Metis MISO I am going to revert this PR |
f4exb
reviewed
Sep 4, 2024
| @@ -622,8 +622,6 @@ void MetisMISOUDPHandler::processIQBuffer(unsigned char* buffer) | |||
| } | |||
| } | |||
|
|
|||
| sampleMic = (int)((signed char) buffer[b++]) << 8; | |||
| sampleMic += (int)((unsigned char)buffer[b++]); | |||
There was a problem hiding this comment.
This is a breaking change and I don't see the point of it.
There was a problem hiding this comment.
b is modified and used though.
There was a problem hiding this comment.
Yes, you're right! Didn't noticed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's fixes for building for Android platform: